[PATCH] D28037: [PowerPC, DAGCombiner] Change vec_sl to a << (b % (sizeof(a) * 8)), and fold it back to a << b.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 16:13:53 PST 2017


echristo added a comment.

One inline comment for the clang part and then let's split the llvm part out into a separate patch please.

Thanks!

-eric



================
Comment at: clang/lib/Headers/altivec.h:8045
 /* vec_sl */
 
 static __inline__ vector unsigned char __ATTRS_o_ai
----------------
Can you add a note here that these functions are documented to return a shift with the shift operand modulo the size of the type?


https://reviews.llvm.org/D28037





More information about the llvm-commits mailing list