[PATCH] D28095: [ELF] - Use information available from DW_AT_comp_dir attribute when doing error reporting.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 15:45:35 PST 2017


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:57
 
 template <class ELFT> void elf::ObjectFile<ELFT>::initializeDwarfLine() {
   std::unique_ptr<object::ObjectFile> Obj =
----------------
This function does more than its name says -- you are now initializing not only `DwarfLine` but `CompilationDir`. You probably should save `Dwarf` instead of `DwarfLine` and `CompilationDir`.


https://reviews.llvm.org/D28095





More information about the llvm-commits mailing list