[PATCH] D28182: COFF: tie the execute and the PDB together

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 15:35:33 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/PDB.cpp:151-152
+  assert(DI->Signature.CVSignature == OMF::Signature::PDB70 &&
+         "only PDB 7.0 is supported");
+  InfoBuilder.setAge(DI->PDB70.Age);
+  InfoBuilder.setGuid(
----------------
You already have the same `assert` in the writer, so please remove this from here.


Repository:
  rL LLVM

https://reviews.llvm.org/D28182





More information about the llvm-commits mailing list