[PATCH] D28040: Don't store the NULL DIEs in the DIE array in the DWARFUnit.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 15:30:49 PST 2017


clayborg abandoned this revision.
clayborg added a comment.

There are test failures with the obj2yaml and yaml2obj. After thinking about this patch more, we should probably leave in the NULL DIEs. My reasoning is
the NULLs correctly show the structure of the DWARF without needing any magic to reconstruct the NULL dies like we needed to do when dumping the DWARF. This was easy to work around for the dumping since we were using the getFirstChild()/getSibling() calls, but other clients that just want to walk through the DWARFDebugInfoEntry array, like the obj2yaml, would need to magically reconstruct these extra NULL dies with the correct offset.

So in order to not ruin the accurate representation that we currently have I will leave the NULL dies in.


https://reviews.llvm.org/D28040





More information about the llvm-commits mailing list