[PATCH] D27855: try to extend nonnull-ness of arguments from a callsite back to its parent function

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 14:29:20 PST 2017


spatel added a comment.

In https://reviews.llvm.org/D27855#634465, @chandlerc wrote:

> I've spoken with Richard Smith and he's going to send an email to cfe-dev about handling this in Clang. I'm also writing a paper for the C++ committee to standardize on somewhat more sane handling here. But I think we should at least defend users against the known misuses of this attribute and *then* start optimizing it harder. Are folks OK with that?


That sounds ok to me. We could add a patch dependency here in phab to this, https://reviews.llvm.org/D28204, https://reviews.llvm.org/D27114  (any others?) once the clang patch is posted. 
Given how many places drop the nonnull metadata, I'm surprised we ever get any nullptr optimizations. :)


https://reviews.llvm.org/D27855





More information about the llvm-commits mailing list