[PATCH] D27991: Optimize objdump -objc-meta-data

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Object/MachOObjectFile.cpp:3079
+  assert(
+      (Opcodes.begin() == Other.Opcodes.begin() || Opcodes == Other.Opcodes) &&
+      "compare iterators of different files");
----------------
These changes are technically introducing UB.  Comparing iterators across containers is UB.  So, we need a member-wise comparison.  You can put this under expensive checks if you want though.


https://reviews.llvm.org/D27991