[llvm] r290900 - Enable disabled loopidiom test. Apparently we handle it now

Xin Tong via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 11:08:06 PST 2017


Author: trentxintong
Date: Tue Jan  3 13:08:05 2017
New Revision: 290900

URL: http://llvm.org/viewvc/llvm-project?rev=290900&view=rev
Log:
Enable disabled loopidiom test. Apparently we handle it now

Summary:
Enable disabled loopidiom test. Apparently we handle it now.
Maybe due to improvements to AA.

Reviewers: atrick, danielcdh, hfinkel

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D28171

Modified:
    llvm/trunk/test/Transforms/LoopIdiom/basic.ll

Modified: llvm/trunk/test/Transforms/LoopIdiom/basic.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopIdiom/basic.ll?rev=290900&r1=290899&r2=290900&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/LoopIdiom/basic.ll (original)
+++ llvm/trunk/test/Transforms/LoopIdiom/basic.ll Tue Jan  3 13:08:05 2017
@@ -97,8 +97,7 @@ for.end:
 ; CHECK: ret void
 }
 
-
-;; TODO: We should be able to promote this memset.  Not yet though.
+; Make sure the first store in the loop is turned into a memset.
 define void @test4(i8* %Base) nounwind ssp {
 bb.nph:                                           ; preds = %entry
   %Base100 = getelementptr i8, i8* %Base, i64 1000
@@ -118,9 +117,8 @@ for.body:
 
 for.end:                                          ; preds = %for.body, %entry
   ret void
-; CHECK-TODO-LABEL: @test4(
-; CHECK-TODO: call void @llvm.memset.p0i8.i64(i8* %Base, i8 0, i64 100, i32 1, i1 false)
-; CHECK-TODO-NOT: store
+; CHECK-LABEL: @test4(
+; CHECK: call void @llvm.memset.p0i8.i64(i8* %Base, i8 0, i64 100, i32 1, i1 false)
 }
 
 ; This can't be promoted: the memset is a store of a loop variant value.




More information about the llvm-commits mailing list