[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:371-374
+    if (Best == nullptr)
+      return Other;
+    if (DT.dominates(Best, Other))
+      return Other;
----------------
`if (Best == nullptr || Dt.dominates()) return Other;` 


================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:422-425
+      if ((isa<LoadInst>(U) || isa<StoreInst>(U)) &&
+          U->getMetadata(LLVMContext::MD_invariant_group) == InvariantGroupMD) {
+        ClosestDependency = GetClosestDependency(ClosestDependency, U);
+      }
----------------
You probably don't need braces, right?


https://reviews.llvm.org/D28137