[PATCH] D27562: CodeGen: Assert that liveness is up to date when reading block live-ins.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 2 05:43:44 PST 2017


MatzeB added inline comments.


================
Comment at: lib/CodeGen/RegisterScavenging.cpp:54
-  assert(MRI->tracksLiveness() &&
-         "Cannot use register scavenger with inaccurate liveness");
-
----------------
qcolombet wrote:
> Removing that assert seems strange.
> I was thinking this is okay because it will be checked anyway when we use MachineBasicBlock::liveins(), but was this your intent?
Yes, this assert() is redundant now because we have one in MachineBasicBlock::livein_begin() anyway.


https://reviews.llvm.org/D27562





More information about the llvm-commits mailing list