[PATCH] D27997: [AMDGPU] Prevent spills before exec mask is restored

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 2 05:32:10 PST 2017


MatzeB added a comment.

In general I find rules like "no spill may be before a isPositionLike() instruction" dangerous in that they are not at all obvious to people writing generic codegen passes and you run the danger that even if you fix the register allocator other passes may disregard the new rule.

Have you considered alternative solutions? Like having a late pass that moves your exec mask back to the top in a late pass so that the exec mask rules only need to be known by that one pass?


Repository:
  rL LLVM

https://reviews.llvm.org/D27997





More information about the llvm-commits mailing list