[PATCH] D28118: AVX-512 cost calculation for interleave load/store patterns

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 2 00:27:51 PST 2017


mkuper added a comment.

This LGTM, but please also wait for Simon's approval (or disapproval :-) ), just so your patches stay in sync.



================
Comment at: ../lib/Analysis/CostModel.cpp:115
+
+static bool isBroadcastVectorMask(SmallVectorImpl<int> &Mask) {
+  int SplatVal = -1;
----------------
delena wrote:
> RKSimon wrote:
> > I've added a ShuffleVectorInst::isSplat helper in D27811 for the same purpose. It's probably worth you merging that part (inc the CodeGenPrepare.cpp change as well) here.
> The "broadcast" was not the matter of my patch and I do not really investigated in it, just added for completeness. And the broadcast-test is not full. I'd rather remove these changes at all and let you to proceed. 
So, if this goes in first, it'll get removed by Simon's clean-up, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D28118





More information about the llvm-commits mailing list