[PATCH] D23652: [mips] N64 static relocation model support

Zoran Jovanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 16:52:30 PST 2017


zoran.jovanovic accepted this revision.
zoran.jovanovic added a reviewer: zoran.jovanovic.
zoran.jovanovic added a comment.

LGTM with a few nits.



================
Comment at: lib/Target/Mips/Mips64InstrInfo.td:515
 
+def : MipsPat<(MipsJmpLink (i64 texternalsym:$dst)),
+              (JAL texternalsym:$dst)>;
----------------
Nit: Is this definition necessary?
If it is needed for micromips pre-r6 than it can be moved to MicroMipsInstrInfo.td.


================
Comment at: lib/Target/Mips/MipsAsmPrinter.cpp:703
     //        For the moment, I'm only correcting enough to make MIPS-IV work.
     if (!isPositionIndependent() && !ABI.IsN64())
       TS.emitDirectiveOptionPic0();
----------------
Is this condition also affected by the change?


================
Comment at: test/CodeGen/Mips/blockaddr.ll:38
+
+; STATIC-N64: lui	$[[R0:[0-9]]], %highest(.Ltmp[[L0:[0-9]]])
+; STATIC-N64: daddiu	$[[R1:[0-9]]], $[[R0]], %higher(.Ltmp[[L0]])
----------------
Nit: Tab between mnemonic and operands description should be replaced with spaces.


https://reviews.llvm.org/D23652





More information about the llvm-commits mailing list