[PATCH] D28197: [X86] Re-organize tests for bypassing slow division (NFC)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 15:07:00 PST 2017


RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

In https://reviews.llvm.org/D28197#633174, @n.bozhenov wrote:

> > on the assumption that these are just renames
>
> That's not true. There are changes beside renaming. I will create an auxiliary review without renaming so that one can easily review the actual diff between old and new files.


I don't think another review is necessary - just commit the renames only first and then make the changes in the now renamed files in a follow up commit. Make sense?


https://reviews.llvm.org/D28197





More information about the llvm-commits mailing list