[PATCH] D28147: [LICM] Allow promotion of some stores that are not guaranteed to execute

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 31 14:25:09 PST 2016


sanjoy added a comment.

In https://reviews.llvm.org/D28147#632595, @mkuper wrote:

> So, the patch is now fairly small, but I'm having trouble with the testcases.
>  In particular, I think what we have now is unsound, because isGuaranteedToTransferExecutionToSuccessor() returns true for argmemonly calls, which means that things that should only get promoted with my patch get promoted without.


That was an oversight, fixed in https://reviews.llvm.org/rL290794

> I'll get back to this on Tuesday. For now, I'll upload the code change, without fixing the tests, in case you want to take a look at the semantic change.




https://reviews.llvm.org/D28147





More information about the llvm-commits mailing list