[PATCH] D28193: NewGVN: Add UnknownExpression and create them for things we can't symbolize. Kill fragile machinery for handling null expressions.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 23:59:52 PST 2016


dberlin created this revision.
dberlin added a reviewer: davide.
dberlin added a subscriber: llvm-commits.

This avoids the very fragile code for null expressions. We could also use a denseset that tracks which things have null expressions instead, but that seems pretty fragile and premature optimization.

This resolves a number of infinite loop cases, test reductions coming.


https://reviews.llvm.org/D28193

Files:
  include/llvm/Transforms/Scalar/GVNExpression.h
  lib/Transforms/Scalar/NewGVN.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28193.82758.patch
Type: text/x-patch
Size: 4668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161231/11aa6ee0/attachment.bin>


More information about the llvm-commits mailing list