[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 15:36:43 PST 2016


> On Dec 30, 2016, at 3:26 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
> 
> 
> PS: consider sending replies in phabricator, because email replies sometimes doesn't appear there (like this one)
> 
> I'm strongly against that, in the sense that phabricator needs to integrate with existing workflows.  I do real reviews in phab, but just overall commenting, don't have time or energy to click when i'm reading email :)
> 
> If email to phabricator is not currently working, we should fix that.
> (I believe it is *supposed to be working*)

Inline answer in emails never worked in Phab. AFAIK.
It use to be that top answers were included as comment. But even that was not in Phab upstream but in our instance only (IIUC), so it can easily have been lost with any update.

—
Mehdi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161230/475b72aa/attachment-0001.html>


More information about the llvm-commits mailing list