[llvm] r290767 - [doc] Clarify steps for contributors without commit access.

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 13:28:30 PST 2016


Author: fhahn
Date: Fri Dec 30 15:28:30 2016
New Revision: 290767

URL: http://llvm.org/viewvc/llvm-project?rev=290767&view=rev
Log:
[doc] Clarify steps for contributors without commit access.

Summary: Update the Phabricator docs to clarify how changes are merged for contributors without commit access. 

Reviewers: delcypher, aaron.ballman

Subscribers: aaron.ballman, anmol, llvm-commits

Differential Revision: https://reviews.llvm.org/D28184

Modified:
    llvm/trunk/docs/Phabricator.rst

Modified: llvm/trunk/docs/Phabricator.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/Phabricator.rst?rev=290767&r1=290766&r2=290767&view=diff
==============================================================================
--- llvm/trunk/docs/Phabricator.rst (original)
+++ llvm/trunk/docs/Phabricator.rst Fri Dec 30 15:28:30 2016
@@ -128,8 +128,12 @@ Committing a change
 -------------------
 
 Once a patch has been reviewed and approved on Phabricator it can then be
-committed to trunk.  There are multiple workflows to achieve this. Whichever
-method you follow it is recommend that your commit message ends with the line:
+committed to trunk. If you do not have commit access, someone has to
+commit the change for you (with attribution). It is sufficient to add
+a comment to the approved review indicating you cannot commit the patch
+yourself. If you have commit access, there are multiple workflows to commit the
+change. Whichever method you follow it is recommend that your commit message
+ends with the line:
 
 ::
 




More information about the llvm-commits mailing list