[PATCH] D28184: [doc] Clarify steps for contributors without commit access.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 12:40:07 PST 2016


fhahn created this revision.
fhahn added a reviewer: delcypher.
fhahn added a subscriber: llvm-commits.

Update the Phabricator docs to clarify how changes are merged for contributors without commit access.


https://reviews.llvm.org/D28184

Files:
  docs/Phabricator.rst


Index: docs/Phabricator.rst
===================================================================
--- docs/Phabricator.rst
+++ docs/Phabricator.rst
@@ -128,8 +128,12 @@
 -------------------
 
 Once a patch has been reviewed and approved on Phabricator it can then be
-committed to trunk.  There are multiple workflows to achieve this. Whichever
-method you follow it is recommend that your commit message ends with the line:
+committed to trunk. If you do not have commit access, somebody else has to
+commit the change for you (with attribution). Usually it is sufficient to add
+a comment to the approved review indicating you cannot commit the patch
+yourself. If you have commit access, there are multiple workflows to commit the
+change. Whichever method you follow it is recommend that your commit message
+ends with the line:
 
 ::
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28184.82741.patch
Type: text/x-patch
Size: 839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161230/5c872c07/attachment.bin>


More information about the llvm-commits mailing list