[PATCH] D24510: [mips] Correct c.cond.fmt instruction definition.

Zoran Jovanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 08:35:03 PST 2016


zoran.jovanovic accepted this revision.
zoran.jovanovic added a comment.

LGTM with a nit.



================
Comment at: test/MC/Mips/mips1/invalid-mips2-wrong-error.s:17
         sdc3      $12,5835($t2)   # CHECK: :[[@LINE]]:{{[0-9]+}}: error: invalid operand for instruction
+        c.eq.s    $fcc1, $f2, $f8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: invalid operand for instruction
+        c.f.s     $fcc4, $f2, $f7 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: invalid operand for instruction
----------------
Nit: I can see that same error message is generated for bc1t and bc1f instructions and those are located in invalid-mips4.s test file.
Is expected error message different for these instructions or they should be placed in same file?
Same stands for corresponding test cases for mips2 and mips3.


https://reviews.llvm.org/D24510





More information about the llvm-commits mailing list