[PATCH] D26989: Use continuous boosting factor for complete unroll.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 29 16:01:08 PST 2016


danielcdh added a comment.

In https://reviews.llvm.org/D26989#632450, @chandlerc wrote:

> I'm good with the patch now, thanks (see nit picks below, but no need to refresh the patch, just fix prior to submitting).
>
> I would like to see at least code size numbers for the llvm test suite benchmarks before you submit. (I'm interested if there are runtime changes, but not really worried about them.) If the code size doesn't regress significantly (as SPEC doesn't), LGTM.


The code size does not change except for the following 2 binaries:

CMakeFiles/CheckTypeSize/CMAKE_SIZEOF_UNSIGNED_SHORT.bin 8112->8104 (0.1%)
CMakeFiles/TestEndianess.bin 8096->8088 (0.1%)

The run time did not change.


https://reviews.llvm.org/D26989





More information about the llvm-commits mailing list