[PATCH] D28156: Add the 'googlemock' component of Google Test to LLVM's unittest libraries.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 29 10:26:34 PST 2016


mehdi_amini added a comment.

> It makes writing expectations in tests *dramatically* easier. A quick example that is a taste of what is possible:

These matcher are cool, but why are they part of gmock and not gtests?

> For a concrete example of where this is currently causing significant pain, look at the pass manager unittests which are riddled with counters incremented when methods are called. All of these could be replaced with mocks.

Looks cool, but can you submit another patch with the PM unittests updated with using gmock so we can have a better idea of what you mean here?


https://reviews.llvm.org/D28156





More information about the llvm-commits mailing list