[PATCH] D22949: Speed up Function::isIntrinsic() by adding a bit to GlobalValue. NFC

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 14:22:20 PST 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM, let's ship it.

I alse hear Justin's concern here, especially what he wrote up on the mailing list. However, I like one thing he said: this will essentially get reverted if/when we go down that path. That seems totally fine to me considering how isolated this change is. When the time comes, it'll be easy and transparent to rip out. I think the performance hack in the interim is worth it, and will also keep us honest as we explore options to fix intrinsics in a more fundamental way by holding the higher performance bar.

-Chandler


https://reviews.llvm.org/D22949





More information about the llvm-commits mailing list