[PATCH] D28121: [AVR] Optimize 16-bit ORs with '0'

Anmol P. Paralkar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 12:52:22 PST 2016


anmol updated this revision to Diff 82615.
anmol marked 2 inline comments as done.
anmol added a comment.

Thank you, for the review.

- Renamed AVRExpandPseudo::expandLogicImmNeeded() to AVRExpandPseudo::isLogicImmOpRedundant()
- AVRExpandPseudo::isLogicImmOpRedundant() is now const qualified.
- Eliminated the temporary, so that the check for redundancy appears in the if's conditional clause. PS: The sense of the check is now inverted relative to the prior version.


https://reviews.llvm.org/D28121

Files:
  lib/Target/AVR/AVRExpandPseudoInsts.cpp
  test/CodeGen/AVR/PR31344.ll
  test/CodeGen/AVR/integration/blink.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28121.82615.patch
Type: text/x-patch
Size: 4147 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161228/19151db0/attachment.bin>


More information about the llvm-commits mailing list