[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 09:19:20 PST 2016


Prazek marked 8 inline comments as done.
Prazek added inline comments.


================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:911
   Result.clear();
-
+  {
+    auto NonLocalDef = NonLocalDefsCache.find(QueryInst);
----------------
davide wrote:
> Prazek wrote:
> > davide wrote:
> > > why do you need a different scope?
> > This function is pretty large, so I prefer not to add new names with that huge scope.
> I agree it's large, maybe in a separate commit you can try splitting into multiple functions?
> Not sure how much is buying us as MemDep will go away soon'ish (6 months to 1 year)  but it's worth a try.
I will see what I can do about it, but I guess it is more worth to implement !invariant.group in MemSSE


https://reviews.llvm.org/D28137





More information about the llvm-commits mailing list