[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 08:12:35 PST 2016


Prazek added inline comments.


================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:911
   Result.clear();
-
+  {
+    auto NonLocalDef = NonLocalDefsCache.find(QueryInst);
----------------
davide wrote:
> why do you need a different scope?
This function is pretty large, so I prefer not to add new names with that huge scope.


================
Comment at: test/Transforms/NewGVN/invariant.group.ll:345-347
+; CHECK-LABEL: define void @handling_loops()
+define void @handling_loops() {
+  %a = alloca %struct.A, align 8
----------------
davide wrote:
> Thanks for adding NewGVN tests (although they're still XFAIL'ed, alas).
BTW is there any way we could merge them together keeping the Xfail semantics?


https://reviews.llvm.org/D28137





More information about the llvm-commits mailing list