[PATCH] D28116: [NewGVN] Reduce code duplication for load/store equality

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 09:07:45 PST 2016


davide added a comment.

In https://reviews.llvm.org/D28116#631112, @dberlin wrote:

> Actually, they are identical, aren't they?
>  I don't think you even need to template it


I can use the closest base to {Load,Store}Expression, that is `BasicExpression` instead of the template but that has no `getDefiningAccess()`, do you prefer me to move the function there instead of templating?


https://reviews.llvm.org/D28116





More information about the llvm-commits mailing list