[PATCH] D28092: [ELF] - Specify -section argument for objdump calls in testcases.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 04:27:42 PST 2016


davide added a comment.



In https://reviews.llvm.org/D28092#630614, @grimar wrote:

> In https://reviews.llvm.org/D28092#630613, @davide wrote:
>
> > I don't quite understand the rationale behind this patch. You tried something to speed up which didn't work, so maybe you want to try profiling `llvm-objdump` and see where the time is spent and try to optimize that instead of landing this patch? Also, did you profile the tests execution and actually found out objdump is the real bottleneck? Keep in mind running LLVM tests on Windows is notoriously slower than on *NIX.
>
>
> I am mostly suggest this for consistency. We already use -section argument in many tests. That also has a positive effect when need to debug testcase for some reason. I mean reducing output of sections content is still usefull to have.


Why is reducing the output of objdump useful? If that would have an impact on performance, I'd agree with you, but you realized it hasn't, so, I don't understand what's the real motivation behind this change.
As a side note, this makes slightly more annoying updating tests. If you rename a section, you need to modify two places, and if you're adding a section which you need to dump, then you need to change the linker invocation. Not the end of the world, but why?


https://reviews.llvm.org/D28092





More information about the llvm-commits mailing list