[PATCH] D27205: [PM] Teach the AAManager and AAResults layer (the worst offender for inter-analysis dependencies) to use the new invalidation infrastructure.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 00:58:53 PST 2016


chandlerc added inline comments.


================
Comment at: include/llvm/Analysis/AliasAnalysis.h:206
+  void addAADependencyID(AnalysisKey *ID) {
+    AADeps.push_back(ID);
+  }
----------------
jlebar wrote:
> A thought: It would be cool if our system allowed you to check somehow that this is specifically a function analysis, even if only in debug builds.  (This relates back to e.g. https://reviews.llvm.org/D27198#inline-236718.)
Just wanted to mention I'm not ignoring this, and will be thinking about a clean way to introduce it without complicating things too much.


Repository:
  rL LLVM

https://reviews.llvm.org/D27205





More information about the llvm-commits mailing list