[PATCH] D28119: [InstCombine][X86] Add DemandedElts support for PMULDQ/PMULUDQ instructions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 26 10:41:45 PST 2016


RKSimon created this revision.
RKSimon added reviewers: craig.topper, m_zuckerman, andreadb, spatel.
RKSimon added a subscriber: llvm-commits.
RKSimon set the repository for this revision to rL LLVM.

PMULDQ/PMULUDQ vXi64 instructions only use the even numbered v2Xi32 input elements which SimplifyDemandedVectorElts should try and use.

We can't do much with the undef demanded elts - we should probably only support the (mul X, undef -> 0) pattern the same as regular integer multiplies. I can add support for it if you guys want but I can't see it being used by real world code. Same with constant folding support.


Repository:
  rL LLVM

https://reviews.llvm.org/D28119

Files:
  lib/Transforms/InstCombine/InstCombineCalls.cpp
  lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
  test/Transforms/InstCombine/x86-muldq.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28119.82514.patch
Type: text/x-patch
Size: 8065 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161226/9539073a/attachment.bin>


More information about the llvm-commits mailing list