[PATCH] D28115: RuntimeDyldELF: add support for R_AARCH64_ADD_ABS_LO12_NC

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 26 09:57:02 PST 2016


evgeny777 added inline comments.


================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:42-45
+  if (isBE)
+    write<T, support::big>(P, V);
+  else
+    write<T, support::little>(P, V);
----------------
davide wrote:
> Prefer the ternary operator here:
> `return (isBE) ? write<T, support::big>(...) : write<T, support:little>(...);`
Ok, but it's actually void.


https://reviews.llvm.org/D28115





More information about the llvm-commits mailing list