[PATCH] D28115: RuntimeDyldELF: add support for R_AARCH64_ADD_ABS_LO12_NC

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 26 09:18:45 PST 2016


davide added a comment.

In https://reviews.llvm.org/D28115#631088, @evgeny777 wrote:

> Addressed review comments. 
>  Now lld and RuntimeDyldELF uses two identical sets of helper functions, so it probably makes sense to move them to header file and provide patch for lld.


Maybe. I have no opinions on the topic (bluntly, I don't care), but there have been discussions recently about sharing code between the JIT and the static linker. You may want to check with the involved parties before going on, but I think it makes sense to do this as a follow-up.


https://reviews.llvm.org/D28115





More information about the llvm-commits mailing list