[PATCH] D27901: [X86][[AVX512] Code size reduction in X86 by replacing EVEX with VEX encoding

[Gadi Haber via Phabricator via llvm-commits]

gadi.haber marked 2 inline comments as done.
gadi.haber added inline comments.


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:219
+    MI.setDesc(MCID);
+    MI.setAsmPrinterFlag((MachineInstr::CommentFlag)AC_EXEX_2_VEX);
+    Changed = true;
----------------
zvi wrote:
> Now that this API takes also target-specific flags, I think that instead of casting, setAsmPrinterFlag(CommentFlag) (and friends) should be changed to setAsmPrinterFlag(uint8_t) or something similar.
There is only single definition of setAsmPrinterFlag in MachineInstr.h and it receives the CommenFlag parameter.



Repository:
  rL LLVM

https://reviews.llvm.org/D27901