[PATCH] D28041: IR: Module summary representation for type identifiers; summary test scaffolding for lowertypetests.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:401
+  // FIXME: Add bitcode read/write support for this field.
+  std::map<std::string, TypeIdSummary> TypeIdMap;
+
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > Is this supposed to be "per module" or should it end up global to the index? (My understanding was the latter but you implemented the former AFAICT).
> Mehdi: What makes this per-module vs global? The same ModuleSummaryIndex data structure is used for both the permodule index and the combined index.
> 
> pcc: Why no accessors for this map?
Oh forget my comment, I mis-identified the enclosing class.


https://reviews.llvm.org/D28041