[PATCH] D28040: Don't store the NULL DIEs in the DIE array in the DWARFUnit.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 09:06:15 PST 2016


clayborg marked 4 inline comments as done.
clayborg added a comment.

Marked things as done.



================
Comment at: tools/dsymutil/DwarfLinker.cpp:1799
   if (DIE.hasChildren())
-    for (auto Child = DIE.getFirstChild(); Child && !Child.isNULL();
-         Child = Child.getSibling())
+    for (auto Child = DIE.getFirstChild(); Child; Child = Child.getSibling())
       Info.Prune &= analyzeContextInfo(Child, MyIdx, CU, CurrentDeclContext,
----------------
Let me know if you guys want me to do the iterator thing in this patch?


https://reviews.llvm.org/D28040





More information about the llvm-commits mailing list