[PATCH] D27957: [scudo] ARM32 support

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 08:40:16 PST 2016


rengolin added a comment.

Hi Kostya,

What's the point of adding a review if you're going to commit anyway?

http://llvm.org/docs/DeveloperPolicy.html#code-reviews

"once a patch is sent out for review, it needs an explicit “looks good” before it is submitted. Do not assume silent approval, or request active objections to the patch with a deadline."

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D27957





More information about the llvm-commits mailing list