[PATCH] D27592: Reimplement depedency tracking in the ImplicitNullChecks pass

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 07:56:58 PST 2016


anna added inline comments.


================
Comment at: lib/CodeGen/ImplicitNullChecks.cpp:374
 
-  HazardDetector HD(*TRI, *AA);
+  SmallVector<MachineInstr *, 8> InstsSeenSoFar;
 
----------------
sanjoy wrote:
> anna wrote:
> > Just curious if there's any reason for choosing 8? I think the usual number for any sort of llvm related threshold is 6?
> No reason -- 8 just seemed "more than enough".  I can change it to 6 if feel strongly about it.
8 is fine.


https://reviews.llvm.org/D27592





More information about the llvm-commits mailing list