[PATCH] D28041: IR: Module summary representation for type identifiers; summary test scaffolding for lowertypetests.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 22:31:24 PST 2016


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:646
+
+} // End yaml namespace
 } // End llvm namespace
----------------
mehdi_amini wrote:
> Could these all go in an implementation file with proper forward declaration here?
Alternatively, what about extracting this into a separate header `llvm/include/llvm/IR/ModuleSummaryIndexSerialization.h` that would include `llvm/include/llvm/IR/ModuleSummaryIndex.h` (if necessary).


https://reviews.llvm.org/D28041





More information about the llvm-commits mailing list