[PATCH] D27688: [framelowering] Skip dbg values when getting next/previous instruction.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 10:49:34 PST 2016


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

I think this looks good now. Thanks! (one comment inline)



================
Comment at: lib/Target/X86/X86FrameLowering.cpp:377
+    ? nullptr : skipDebugInstructionsForward(std::next(MBBI), MBB.end());
+
   unsigned Opc = PI->getOpcode();
----------------
Perhaps this would be easier to read if skipDebugInstructions* are on a subsequent line outside the :? expression?


https://reviews.llvm.org/D27688





More information about the llvm-commits mailing list