[PATCH] D27766: [buildbot] Added CUDATestsuiteBuilder.py

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: zorg/buildbot/builders/CUDATestsuiteBuilder.py:2
+from buildbot.process.properties import WithProperties
+from buildbot.plugins import steps
+from zorg.buildbot.builders import ClangBuilder
----------------
gkistanova wrote:
> For the version of the buildbot we use, it should be
> `from buildbot.steps.slave import RemoveDirectory`
> 
> and it used just as `RemoveDirectory` below.
Buildbot seems to be moving RemoveDirectory all over the place in different versions.
I've changed the code to try loading it in a way that should work with both 0.8.5 and 0.8.12.


================
Comment at: zorg/buildbot/builders/CUDATestsuiteBuilder.py:156
+    # If we've enabled thrust tests, build them now.
+    # WARNING: This takes a lot of time to build.
+    if (enable_thrust_tests):
----------------
gkistanova wrote:
> If it takes a long to build and there is no TTY output during that time, you may want to set a longer timeout for this step.
Individual compilations should be well within default timeout of 20 minutes.



https://reviews.llvm.org/D27766