[PATCH] D27948: [libFuzzer] Diff 37 - [FuzzerSupport] Decouple UtilIO from external Functions.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 10:12:15 PST 2016


zturner added a comment.

The logic is not 100% equivalent here.  I don't know how much this matters, but if the `DuplicateFile` call succeeds but the `OpenFile` call fails, then the original logic would not call `__sanitizer_set_report_fd`.  In the new logic, it will.  I don't know how likely this is to happen, so maybe the decoupling here is worth it until we have an issue with this edge case in practice.


Repository:
  rL LLVM

https://reviews.llvm.org/D27948





More information about the llvm-commits mailing list