[PATCH] D28018: AMD family 17h (znver1) enablement

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 04:12:59 PST 2016


RKSimon added inline comments.


================
Comment at: lib/Basic/Targets.cpp:3157
+    setFeatureEnabledImpl(Features, "avx2", true);
+    setFeatureEnabledImpl(Features, "avx", true);
+    setFeatureEnabledImpl(Features, "adx", true);
----------------
Don't need to specify avx as you have avx2


================
Comment at: lib/Basic/Targets.cpp:3177
+    setFeatureEnabledImpl(Features, "xsaves", true);
+    break;
   case CK_BDVER4:
----------------
SSE4A?


Repository:
  rL LLVM

https://reviews.llvm.org/D28018





More information about the llvm-commits mailing list