[PATCH] D28005: Add a unit field to DIGlobalVariable, mirroring the design of DISubprogram.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 16:32:31 PST 2016


aprantl added inline comments.


================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:1681
+  const uint64_t HasUnitFlag = 1 << 1;
+  Record.push_back((uint64_t)N->isDistinct() | HasUnitFlag);
   Record.push_back(VE.getMetadataOrNullID(N->getScope()));
----------------
Note that I accidentally overwrote my correct bitocde upgrade code with an older revision while separating this patch out of my WIP D26769 patch. Will post the correct code and a bitcode upgrade testcase here soon.


https://reviews.llvm.org/D28005





More information about the llvm-commits mailing list