[PATCH] D27807: [globalisel] Initialize RegisterBanks with static data. Part 1 of 2.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 11:43:54 PST 2016


qcolombet added a comment.

> The problem with this is that BitVector needs to know its size in advance and this information is obtained from the TRI which doesn't exist at initialization-time.

IIRC, we get this information statically when we do the generation of TargetRegisterInfo. I suspect we would need to refactor that code to reuse it here, but in the end, everything should be static and this finishInit should not be here.

> That was my first approach but I was asked to create the static tables in advance and follow it with an NFC tablegen patch.

I believe the NFC approach is not incompatible with a change of representation in the same patch.


https://reviews.llvm.org/D27807





More information about the llvm-commits mailing list