[PATCH] D26878: [GlobalISel] Add tentative Selector-emitted tablegen backend.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: include/llvm/Target/TargetGlobalISel.td:23
+  Instruction I = i;
+}
+
----------------
dsanders wrote:
> qcolombet wrote:
> > Just a forward looking thought. Do you think that we would need to support 1 to many patterns?
> > E.g., what will be the strategy for BUILD_VECTOR and the kind?
> > 
> > I am starting to think that we are defining patterns, just target independent ones.
> We haven't used it yet so I can't be sure but G_SEQUENCE seems like the gMIR equivalent of BUILD_VECTOR. Is that right?
Yep, that's a poor example. SEXTLOAD is probably a better one. 


https://reviews.llvm.org/D26878