[PATCH] D27834: AMDGPU/SI: Add a MachineMemOperand when lowering llvm.amdgcn.buffer.load.*

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 08:36:48 PST 2016


tstellarAMD marked 3 inline comments as done.
tstellarAMD added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.h:489
 
+  AMDGPUBufferPseudoSourceValue *getBufferPSV() {
+    return BufferPSV.get();
----------------
arsenm wrote:
> const ,const. You can probably return const &
I left that as returning a pointer, because that's what MachinePointerInfo expects and that matches what the PseudoSourceValue::get*() functions do.


https://reviews.llvm.org/D27834





More information about the llvm-commits mailing list