[PATCH] D27973: [ELF] - Do not call fatal() in Target.cpp, call error() instead.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

In https://reviews.llvm.org/D27973#627791, @grimar wrote:

> In https://reviews.llvm.org/D27973#627788, @davide wrote:
>
> > Instead of checking in a binary, I'll see if you can craft a broken object using `yaml2obj`.
> >  I'm not a huge fan of the tool itself, but I find this a very legitimate usecase for it (creating broken binaries).
>
>
> No it looks not possible. It showed me a error when I tried to create a relocation using numeric value and not a pre-defined enum. So I believe it is a unreasonable limitaion of yaml2obj now.


Can you please take a look at how hard is to fix `yaml2obj` for this testcase? I think we should avoid checking in a binary unless really necessary, as it makes reconstructing the testcase harder in the future.


https://reviews.llvm.org/D27973