[PATCH] D27875: IR: Eliminate non-determinism in the module summary analysis.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 19:30:40 PST 2016


tejohnson added a comment.

This looks like a good cleanup. One minor suggestion below. I see Mehdi just responded with a couple of suggestions, so will hold off on accepting for now.



================
Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:138
         // aliasee.
-        auto *CalleeId =
-            M.getValueSymbolTable().lookup(CalledValue->getName());
+        auto *CalleeId = cast<GlobalValue>(CalledValue);
 
----------------
CalleeId doesn't seem like the best name anymore. Just "Callee"?


https://reviews.llvm.org/D27875





More information about the llvm-commits mailing list