[PATCH] D27808: [globalisel] Initialize RegisterBanks with static data. Part 2 of 2.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 17:37:07 PST 2016


qcolombet requested changes to this revision.
qcolombet added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/llvm/CodeGen/GlobalISel/RegisterBank.h:36
+    uint64_t CoveredClasses;
   } DataTy;
 
----------------
I would directly give access to the field instead of having an intermediate structure.
Just add a comment that those shouldn't be touched because they are tablegen'ed.

At the same time, we would eliminate the default constructor and the friend relationship with the RegisterBankInfo.
Have a look to TargetRegisterClass.


https://reviews.llvm.org/D27808





More information about the llvm-commits mailing list