[PATCH] D27114: Preserve nonnull metadata on Loads through SROA & mem2reg.

Luqman Aden via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 16:28:44 PST 2016


luqmana added a comment.

In https://reviews.llvm.org/D27114#627071, @efriedma wrote:

> > Lines 361-381 assert that LI is dominated by the Store and the Store trivially dominates ReplVal?
>
> Post-dominates, not dominates... they're sort of similar, but post-dominance involves following the control flow edges the other way.  A compiler textbook should cover this.


Ah yes, missed that detail. Updated to also consider post-dominance.


https://reviews.llvm.org/D27114





More information about the llvm-commits mailing list