[PATCH] D27931: Fix corner cases of setting the section address

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 10:51:26 PST 2016


grimar accepted this revision.
grimar added a reviewer: grimar.
grimar added a comment.
This revision is now accepted and ready to land.

I am happy, looks this just works. (with nit)



================
Comment at: lld/ELF/Writer.cpp:1729
+                              ArrayRef<OutputSectionBase *> OutputSections);
+template void
+elf::allocateHeaders<ELF32BE>(MutableArrayRef<PhdrEntry> Phdrs,
----------------
Please remove argument names here and below:
```
elf::allocateHeaders<ELF32LE>(MutableArrayRef<PhdrEntry>,
                              ArrayRef<OutputSectionBase *>);
```


https://reviews.llvm.org/D27931





More information about the llvm-commits mailing list